-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dashboards): Updating grafana dashboards and adding them to Grafana Portal #1285
base: main
Are you sure you want to change the base?
chore(dashboards): Updating grafana dashboards and adding them to Grafana Portal #1285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a couple of screenshots for each Grafana dashboards in the PR description? This can serve as a test for this PR.
Added. |
I can't see traffic on Pod-Traffic dashboards, but that would be a separate issue.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove/replace this in dashboards:
"content": "# Network Observability Metrics\n\nUse this dashboard to visualise metrics from the Network Observability add-on for AKS. Dashboard displays metrics from Linux and Windows Clusters. To hide the irrelevant metrics, simply collapse the unwanted sections. Alternatively, you can edit the dashboard to delete unwanted panels. For any questions or issues, please see our documentation.",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending review from @huntergregory
Thanks @huntergregory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove any other mentions of AKS / netobs addon? For instance, the documentation link ought to point to retina
I'm pretty sure I have covered this. But I'll do another search everywhere to make sure I didn't miss anything. |
All mentions to network observability (names, tags and documentation) have been updated to point to Retina in the last commit. |
….com/apontejaj/retina into amilcara/updating-grafana-dashboards
….com/apontejaj/retina into amilcara/updating-grafana-dashboards
Description
This PR cover multiple aspects regarding Grafana Dashboards.
deploy/grafana-dashboards/
Related Issue
pods and dns dashboards are not part of the published Grafana dashboards #178
Screenshots (if applicable) or Testing Completed
Only names are changed on the dashboards. Layouts and queries remain the same.
Checklist
git commit -S -s ...
). See this documentation on signing commits.Additional Notes
New Retina Grafana account has been created as part of this PR.
Also, the scope has been extended to cover dashboards for Hubble control plane which was not mentioned in the original issue.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.