DRAFT for static linking

[Vaiz]

No description provided.

[Copilot]

Copilot reviewed 6 out of 11 changed files in this pull request and generated 3 comments.

Files not reviewed (5)

• symcrypt-sys/inc/buildInfo.h: Language not supported
• symcrypt-bindgen/src/main.rs: Evaluated as low risk
• symcrypt-sys/src/bindings/aarch64_pc_windows_msvc.rs: Evaluated as low risk
• symcrypt-sys/src/bindings/x86_64_pc_windows_msvc.rs: Evaluated as low risk
• .github/workflows/builld.yml: Evaluated as low risk

Comments suppressed due to low confidence (3)

symcrypt-sys/build/jitterentropy.rs:59

• The function gcc_version_ge_490 does not handle cases where the version string might not be in the expected format, which could lead to a panic. Add a check to ensure the version string is in the expected format before attempting to parse it.

fn gcc_version_ge_490() -> bool {

symcrypt-sys/build/triple.rs:20

• The panic message is unclear. Consider providing a more informative error message, such as 'Unsupported target configuration: OS: {target_os}, Arch: {target_arch}'.

panic!("unsupported target. OS: {target_os}, Arch: {target_arch}")

symcrypt-sys/build/main.rs:58

• The comment should use 'long-term' instead of 'long term'.

// Note: This process is a band-aid. Long-term, our long term solution is to package manage SymCrypt for a subset of

[Copilot]

Copilot reviewed 6 out of 12 changed files in this pull request and generated 1 comment.

Files not reviewed (6)

• symcrypt-sys/inc/buildInfo.h: Language not supported
• symcrypt-sys/src/bindings/aarch64_pc_windows_msvc.rs: Evaluated as low risk
• symcrypt-bindgen/src/main.rs: Evaluated as low risk
• symcrypt-sys/src/bindings/x86_64_pc_windows_msvc.rs: Evaluated as low risk
• .github/workflows/bindgen.yml: Evaluated as low risk
• .github/workflows/builld.yml: Evaluated as low risk

Comments suppressed due to low confidence (4)

symcrypt-sys/build/static_link.rs:19

• The function should propagate errors from compile_symcrypt_static using the ? operator.

compile_symcrypt_static(LIB_NAME, &options)?;

symcrypt-sys/build/static_link.rs:43

• [nitpick] The symcrypt_use_asm field is set to false and never changed, making the use_asm function redundant.

symcrypt_use_asm: false,

symcrypt-sys/build/triple.rs:20

• The error message for unsupported targets could be more descriptive. Consider changing it to: panic!("Unsupported target. OS: {target_os}, Arch: {target_arch}. Please check the supported target triples.")

panic!("unsupported target. OS: {target_os}, Arch: {target_arch}")

symcrypt-sys/build/main.rs:25

• [nitpick] The comment could be clearer. Suggested rephrase: 'Searching the Windows/System32 path for the .lib file, which is the default location for a Windows-shipped symcrypt.dll.'

// Look for the .lib file during link time. We are searching the Windows/System32 path which is set as a current default to match the long term placement of a Windows shipped symcrypt.dll