Add support for MirroredAzureDatabricksCatalog in create_shortcut_onelake() #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… OneLake shortcuts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary & Background
Dan mentions in this comment that the newly merged PR for
_shortcuts.pydid not include support for the Mirrored Azure Databricks Catalog item type.This PR adds support for creating shortcuts to Mirrored Azure Databricks Catalogs.
The core logic handles this scenario since the JSON payload passes in an
item_id, and we get the item id fromresolve_item_name_and_idwhich should handle thissource_item_type. In this PR we are just updating thesource_item_typeto be able to handle "MirroredAzureDatabricksCatalog" as a value without returning an error.Note
I do not have access to a Mirrored Azure Databricks Catalog in my environment so I was not able to test the code changes. Someone else may need to test, but I believe it should work as-is.