Skip to content

Port "Deemphasize old JSX transform" #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

Port "Deemphasize old JSX transform" #1809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/tsoptions/enummaps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,9 @@ var moduleDetectionOptionMap = collections.NewOrderedMapFromList([]collections.M
var jsxOptionMap = collections.NewOrderedMapFromList([]collections.MapEntry[string, any]{
{Key: "preserve", Value: core.JsxEmitPreserve},
{Key: "react-native", Value: core.JsxEmitReactNative},
{Key: "react", Value: core.JsxEmitReact},
{Key: "react-jsx", Value: core.JsxEmitReactJSX},
{Key: "react-jsxdev", Value: core.JsxEmitReactJSXDev},
{Key: "react", Value: core.JsxEmitReact},
})

var InverseJsxOptionMap = collections.NewOrderedMapFromList(func() []collections.MapEntry[core.JsxEmit, string] {
Expand Down
2 changes: 1 addition & 1 deletion testdata/baselines/reference/tsc/commandLine/does-not-add-color-when-NO_COLOR-is-set.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ default: false

--jsx
Specify what JSX code is generated.
one of: preserve, react-native, react, react-jsx, react-jsxdev
one of: preserve, react-native, react-jsx, react-jsxdev, react
default: undefined

--outFile
Expand Down
2 changes: 1 addition & 1 deletion testdata/baselines/reference/tsc/commandLine/help.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ default: false

--jsx
Specify what JSX code is generated.
one of: preserve, react-native, react, react-jsx, react-jsxdev
one of: preserve, react-native, react-jsx, react-jsxdev, react
default: undefined

--outFile
Expand Down
2 changes: 1 addition & 1 deletion ...h-ExitStatus.DiagnosticsPresent_OutputsSkipped-when-host-cannot-provide-terminal-width.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ default: false

--jsx
Specify what JSX code is generated.
one of: preserve, react-native, react, react-jsx, react-jsxdev
one of: preserve, react-native, react-jsx, react-jsxdev, react
default: undefined

--outFile
Expand Down
2 changes: 1 addition & 1 deletion .../reference/tsc/commandLine/show-help-with-ExitStatus.DiagnosticsPresent_OutputsSkipped.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ tsc: The TypeScript Compiler - Version FakeTSVersion

 --jsx Specify what JSX code is generated.

one of: preserve, react-native, react, react-jsx, react-jsxdev
one of: preserve, react-native, react-jsx, react-jsxdev, react

default: undefined

Expand Down
2 changes: 1 addition & 1 deletion ...lines/reference/tscWatch/commandLine/Parse-watch-interval-option-without-tsconfig.json.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ default: false

--jsx
Specify what JSX code is generated.
one of: preserve, react-native, react, react-jsx, react-jsxdev
one of: preserve, react-native, react-jsx, react-jsxdev, react
default: undefined

--outFile
Expand Down
2 changes: 1 addition & 1 deletion ...s/reference/tsoptions/commandLineParsing/parseCommandLine/Parse empty options of --jsx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ FileNames::

Errors::
error TS6044: Compiler option 'jsx' expects an argument.
error TS6046: Argument for '--jsx' option must be: 'preserve', 'react-native', 'react', 'react-jsx', 'react-jsxdev'.
error TS6046: Argument for '--jsx' option must be: 'preserve', 'react-native', 'react-jsx', 'react-jsxdev', 'react'.