Skip to content

Port "Fix #61098" #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

Port "Fix #61098" #1810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions internal/checker/relater.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3298,6 +3298,22 @@ func (r *Relater) structuredTypeRelatedToWorker(source *Type, target *Type, repo
return result
}
}
case source.flags&TypeFlagsTemplateLiteral != 0:
if slices.Equal(source.AsTemplateLiteralType().texts, target.AsTemplateLiteralType().texts) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes needed, but slices.Equal doesn't do a quick check for slice equality (which in go would be a little more complicated) whereas arrayIsEqualTo did. Wonder how much perf we are losing due to the (handful) of calls that were swapped.

result = TernaryTrue
for i, sourceType := range source.AsTemplateLiteralType().types {
targetType := target.AsTemplateLiteralType().types[i]
result &= r.isRelatedTo(sourceType, targetType, RecursionFlagsBoth, false /*reportErrors*/)
if result == TernaryFalse {
return result
}
}
return result
}
case source.flags&TypeFlagsStringMapping != 0:
if source.AsStringMappingType().Symbol() == target.AsStringMappingType().Symbol() {
return r.isRelatedTo(source.AsStringMappingType().target, target.AsStringMappingType().target, RecursionFlagsBoth, false /*reportErrors*/)
}
}
if source.flags&TypeFlagsObject == 0 {
return TernaryFalse
Expand Down
31 changes: 0 additions & 31 deletions ...rence/submodule/compiler/assignmentToConditionalBrandedStringTemplateOrMapping.errors.txt
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions .../submodule/compiler/assignmentToConditionalBrandedStringTemplateOrMapping.errors.txt.diff
View file
Open in desktop

This file was deleted.