Skip to content

Port "Fix Symbol completion priority and cursor positioning" #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2025
Merged

Port "Fix Symbol completion priority and cursor positioning" #1835

merged 1 commit into from
Oct 7, 2025
+1 −0

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Oct 7, 2025 •
edited
Loading

There is no change in tests (yet) because all related tests fail at the first assertDeepEqual call in verifyCompletionItem for other reasons. So the code never reaches assertDeepEqual targeting .SortText

ports microsoft/TypeScript#61945

NathaelB
NathaelB approved these changes Oct 7, 2025
View reviewed changes
Copy link

@NathaelB NathaelB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakebailey jakebailey added this pull request to the merge queue Oct 7, 2025
Merged via the queue into microsoft:main with commit 5a50e1b Oct 7, 2025
22 checks passed
@Andarist Andarist deleted the port/61945 branch October 7, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

+1 more reviewer

@NathaelB NathaelB NathaelB approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andarist @jakebailey @NathaelB