Comment in and fix reportNonDefaultExport #676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
reviewed
Mar 19, 2025
...odule/compiler/es6ImportDefaultBindingFollowedWithNamespaceBindingWithExport.errors.txt.diff
Outdated
Show resolved
Hide resolved
frodi-karlsson
commented
Mar 19, 2025
jakebailey
reviewed
Mar 19, 2025
frodi-karlsson
commented
Mar 19, 2025
There was a problem hiding this comment.
I might be wrong but I think this regression is due to getEmitSyntaxForModuleSpecifierExpression not being implemented, but they're just getting surfaced by these changes. Should I aim to implement that as well to confirm that theory in this PR? I'm torn between scope of changes and want for confidence
There was a problem hiding this comment.
If it's straightforward, what you have I think is already an improvement.
jakebailey
reviewed
Mar 19, 2025
jakebailey
reviewed
Mar 19, 2025
|
What is here seems correct, save for a couple of go-specific nits which I don't think really matter. |
|
Yeah, to go further we need |
jakebailey
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlocked by implied node format