-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vcpkg] clean PR clutters commit #40169
Conversation
The problem is not in the contributor's commit messages, and thus it cannot be caught with regular PR checks because that commit message doesn't exist at that time. The initial post is based on the PR draft message which is unfortunately designed to have commented sections. PR checks would have to fetch the PR's comment via GH API. But you can't really suggest to remove the commented sections which were just suggested by the template. |
@dg0yt |
I guess someone changed repository settings to this. Please change back to
|
I think this is 'the person clicking the merge button needs to do a better job' than something to complain about contributors about. |
@FrankXie05 Thanks for looking in to this. I think the problem @dg0yt was talking about should be resolved now without needing to add more bots. Thanks! |
Fix #37352