Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libxcrypt] fix compile error due to bad array length #41697

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[libxcrypt] fix compile error due to bad array length #41697

wants to merge 1 commit into from
+18 −2

Conversation

WentsingNee
Copy link
Contributor

@WentsingNee WentsingNee commented Oct 21, 2024 •
edited by jimwang118
Loading

Fixes #41695

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@WentsingNee
Copy link
Contributor Author

issue: #41695

@WentsingNee WentsingNee mentioned this pull request Oct 21, 2024
Open
@dg0yt
Copy link
Contributor

dg0yt commented Oct 21, 2024

Submit the patch upstream. Make the port build without -Werror instead.

@WentsingNee
Copy link
Contributor Author

WentsingNee commented Oct 21, 2024 •
edited
Loading

Make the port build without -Werror instead.

Negative, initializing the array with larger length is dangerous. without -Werror is just hide the problem not solve it

@dg0yt
Copy link
Contributor

dg0yt commented Oct 21, 2024 •
edited
Loading

Well, I said upstream it. It was added in besser82/libxcrypt@f7bf4fa. Maybe this was also meant to change ascii64[65].

-Werror is good for controlled CI environments (upstream), but not well suited for portable build recipes (vcpkg).

@WangWeiLin-MV WangWeiLin-MV added the category:port-bug The issue is with a library, which is something the port should already support label Oct 22, 2024
WangWeiLin-MV
WangWeiLin-MV reviewed Oct 22, 2024
View reviewed changes
ports/libxcrypt/fix-base64-bad-length.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source code is modified and needs to be submitted to the upstream.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since a variable in the source code was modified, please submit this fix upstream.

@BillyONeal BillyONeal marked this pull request as draft November 28, 2024 00:21
@BillyONeal
Copy link
Member

I converted this to draft because we need upstream to look. Please feel free to mark 'ready for review' after either upstream has responded, or 30 days, whichever is first.

Alternately, change the patch to remove the -Werror rather than changing the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV left review comments

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libxcrypt] build failure
4 participants
@WentsingNee @dg0yt @BillyONeal @WangWeiLin-MV