-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[or-tools] adds or-tools as new port #42480
base: master
Are you sure you want to change the base?
Conversation
Are there library components here or is this entirely providing a tool? We generally don't put tooling in our registry unless there is some kind of interdependency with the exact tool and some other library component, because we believe binary distribution systems like nuget or apt or dnf are a better fit for those situations. For example, I'm marking this PR as a draft because several builds are failing, please either fix the supports expression to describe what the port actually supports and mark 'ready for review' afterwards. |
This is a library for solving optimization problems. The executables build also (the tools) are not really needed. Your right. I'll try to disable the build of them. I'll also have a look at the supported platforms |
Co-authored-by: Mengna-Li <[email protected]>
Co-authored-by: Mengna-Li <[email protected]>
Co-authored-by: Mengna-Li <[email protected]>
Co-authored-by: Mengna-Li <[email protected]>
Co-authored-by: Mengna-Li <[email protected]>
@JulZimmermann I encountered the following error while testing the usage:
|
@Mengna-Li I disabled the build of the math_opt targets. Now only the really needed ortools target is build. |
Unfortunately, there still seems to be a problem. However, with these settings I have linker errors on linux now. Looks like a bug in the cmake. I'll need to investigate this further. |
On b135bb7: Is this expected to pick system libraries if available? |
@Mengna-Li It seems However, I added a using file describing that only the |
@dg0yt No, system libs shouldn't be used. Did I make a mistake in the port file so they are picked? |
Why shouldn't it be supported to turn it off? That CMake line doesn't enforce it, but adds preqrequisites. |
@dg0yt I'm not sure why the flag exists if it can't be used. That was confusing me too. From
In my opinion these options shouldn't exist if they can't be used. However, because the gurobi lib would be "dynamicaly loaded upon use" there is no hard dependency on gurobi even when |
Upstream bug IMO.
I see... |
|
||
vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS | ||
FEATURES | ||
highs USE_HIGHS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that your format has been restored to its original state.
Note: I will be converting your PR to draft status. When you're ready, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
Adds Google or-tools lib as a port.
highs
solver is useable as an optional featurecoin-or
solver couldn't be added because of [coin-or-cbc] pre-release-version is used #39342. Once this is issue is resolvedcoin-or
can also be added as an optional featurefind_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.