Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exprtk] Add versions 0.0.2 #42996

Closed
wants to merge 1 commit into from
Closed

[exprtk] Add versions 0.0.2 #42996

wants to merge 1 commit into from

Conversation

ArashPartow
Copy link
Contributor

@ArashPartow ArashPartow commented Dec 30, 2024 •
edited
Loading

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.

Closes: #42173, #40270, #33571, #30058, #29955, #29801, #29775, #29665, #38756

@PhoebeHui / @jimwang118 / @JonLiu1993 / @LilyWangLL

@ArashPartow ArashPartow marked this pull request as ready for review December 30, 2024 05:50
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Dec 30, 2024
@LilyWangLL
Copy link
Contributor

The pipeline errors will be fixed by PR #42912.

@LilyWangLL LilyWangLL added the depends:different-pr This PR or Issue depends on a PR which has been filed label Dec 30, 2024
ArashPartow
ArashPartow commented Dec 30, 2024
View reviewed changes
Copy link
Contributor Author

@ArashPartow ArashPartow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will now only contain tag 0.0.2 instead of both 0.0.2 and 0.0.3

@LilyWangLL
Copy link
Contributor

@LilyWangLL can you please revert the change you made specifically: 8770ed9

That version is intentionally there it is tag 0.0.2.

On a side note: Not sure why Github will not allowed me to request a change on my own PR .

In fact, version 2023-01-01 does not exist in vcpkg. This PR directly upgraded from version 2022-01-01 to version 2024-01-01.

@ArashPartow ArashPartow force-pushed the arashpartow/update_exprtk_0.0.3 branch from 24fc06d to 6367623 Compare December 30, 2024 08:27
@LilyWangLL
Copy link
Contributor

The commit for version 2023-01-01 is just a historical submission in this PR. The final data merged in the PR reflects the final changes, just from version 2022-01-01 to version 2024-01-01.

After this PR is merged, users will only be able to install versions 2022-01-01 and 2024-01-01 in vcpkg, and not version 2023-01-01. The data in this JSON file needs to correspond to the changes shown in the image below and should not include any additional modifications.

image

@LilyWangLL LilyWangLL self-requested a review December 30, 2024 08:50
@LilyWangLL
Copy link
Contributor

If you want both versions 2023-01-01 and 2024-01-01 to be installable, you need to submit separate PRs for each version. After version 2023-01-01 is merged, then merge version 2024-01-01.

@LilyWangLL
Copy link
Contributor

@LilyWangLL ok, I'll convert this PR to 2023 and then create another one once this has been merged for 2024, are you ok with me proceeding?

That's great!

@ArashPartow ArashPartow force-pushed the arashpartow/update_exprtk_0.0.3 branch from 6367623 to 0ec126a Compare December 30, 2024 09:56
@ArashPartow ArashPartow changed the title [exprtk] Add versions 0.0.2 and 0.0.3 [exprtk] Add versions 0.0.2 Dec 30, 2024
dg0yt
dg0yt reviewed Dec 30, 2024
View reviewed changes
ports/exprtk/vcpkg.json
@@ -1,7 +1,6 @@
{
"name": "exprtk",
"version-date": "2022-01-01",
"port-version": 2,
"version-date": "2023-01-01",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This port should finally decide which version scheme to use. The subject says 0.0.2, and there is also a tag for it.

Copy link
Contributor

@JavierMatosD JavierMatosD Jan 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArashPartow we should be using the version scheme that upstream uses. In this case, it appears there's a tag for 0.0.3 or use the tag that corresponds with this version, 0.0.2?

@ArashPartow ArashPartow mentioned this pull request Dec 30, 2024
Merged
7 tasks
@ArashPartow ArashPartow reopened this Dec 31, 2024
@ArashPartow ArashPartow reopened this Dec 31, 2024
@LilyWangLL LilyWangLL removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Dec 31, 2024
@ArashPartow ArashPartow mentioned this pull request Dec 31, 2024
Closed
4 tasks
@dg0yt
Copy link
Contributor

dg0yt commented Jan 1, 2025

Not resolved: Use lower-case SHA512 and git ref SHA, #42996 (comment).

Still confusing: Versioning.

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 2, 2025
JavierMatosD
JavierMatosD requested changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@JavierMatosD JavierMatosD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

ports/exprtk/copyright
@@ -1,8 +1,24 @@
Copyright 1999-2022 Arash Partow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that upstream has a license file. Please just install that copyright file rather than checking it in here.

ports/exprtk/vcpkg.json
@@ -1,7 +1,6 @@
{
"name": "exprtk",
"version-date": "2022-01-01",
"port-version": 2,
"version-date": "2023-01-01",
Copy link
Contributor

@JavierMatosD JavierMatosD Jan 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArashPartow we should be using the version scheme that upstream uses. In this case, it appears there's a tag for 0.0.3 or use the tag that corresponds with this version, 0.0.2?

@JavierMatosD JavierMatosD marked this pull request as draft January 3, 2025 17:13
@LilyWangLL LilyWangLL removed the info:reviewed Pull Request changes follow basic guidelines label Jan 6, 2025
@dg0yt dg0yt mentioned this pull request Jan 10, 2025
Merged
@vicroms
Copy link
Member

vicroms commented Feb 7, 2025

Version 0.0.3 has been merged in the registry. Our policy is to take the latest versions of each package.

@vicroms vicroms closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@JavierMatosD JavierMatosD JavierMatosD requested changes

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArashPartow @LilyWangLL @dg0yt @vicroms @JavierMatosD