Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libmagic] fix error hash #43635

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

Mengna-Li
Copy link
Contributor

Fixes #43565.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Mengna-Li Mengna-Li added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Feb 5, 2025
@Mengna-Li Mengna-Li marked this pull request as ready for review February 5, 2025 07:07
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Feb 5, 2025
SHA512 9165bb5bdbe7b8fccac0c8675d4eb251a286ab2ab7a79e6f8ed98d36fa0928b889cf109c1da3a5cfff64d1b1006b5d73934c2d420484adae6f4c8e26a9ede18f
SHA512 fb8157ee8065feaf57412ccdeee57cd8fc853b54ac49b0ddc818eeb1ca3555a7cfd25dea08996503f7c565dcba8c57fd7e4dc5fe3452872c617f5612a94a8f0e
Copy link
Member

@BillyONeal BillyONeal Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming the difference between these two SHAs is:

Beyond Compare showing the difference between the two SHAs

In future updates, should we switch REF to be a commit SHA given that upstream seems to be changing the tag? (I just merged your fix here as it had passed testing and that didn't seem worth forcing a rebuild for...)

@BillyONeal BillyONeal merged commit a0f974c into microsoft:master Feb 5, 2025
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the update!

autoantwort pushed a commit to autoantwort/vcpkg that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libmagic] build failure
3 participants