Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[duckdb] new port #43717

Merged
merged 6 commits into from
Feb 12, 2025
Merged

[duckdb] new port #43717

merged 6 commits into from
Feb 12, 2025

Conversation

m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Feb 9, 2025

Adds a new duckdb port, this is based on #34607
Vendored dependencies which are not properly namespaced have been removed as a result of the discussion in #34607 .

@m-kuhn m-kuhn force-pushed the duckdb branch 3 times, most recently from 43906ef to 01d5777 Compare February 9, 2025 16:13
@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 10, 2025
@MonicaLiu0311
Copy link
Contributor

All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

The usage test passed on x64-windows (header files found).

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Feb 10, 2025
BillyONeal
BillyONeal reviewed Feb 11, 2025
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ports/duckdb/portfile.cmake Outdated Show resolved Hide resolved
ports/duckdb/vcpkg.json Outdated Show resolved Hide resolved
ports/duckdb/usage Outdated Show resolved Hide resolved
ports/duckdb/vcpkg.json Outdated Show resolved Hide resolved
ports/duckdb/vcpkg.json Outdated Show resolved Hide resolved
ports/duckdb/portfile.cmake Outdated Show resolved Hide resolved
@m-kuhn
Copy link
Contributor Author

m-kuhn commented Feb 11, 2025

Thanks for the review @BillyONeal all comments have been addressed

BillyONeal
BillyONeal reviewed Feb 12, 2025
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take a look at m-kuhn#3 ?

ports/duckdb/unvendor_icu.patch Outdated Show resolved Hide resolved
ports/duckdb/usage Outdated Show resolved Hide resolved
versions/d-/duckdb.json Show resolved Hide resolved
@m-kuhn
Merge pull request #3 from BillyONeal/pr_43717_duckdb_fixes
c8aeec4 
Add missing find_dependency calls, ICU::uc, and fix version database.
@m-kuhn
Fix usage
8b376dc
@BillyONeal BillyONeal merged commit cefd534 into microsoft:master Feb 12, 2025
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the new port!

@m-kuhn m-kuhn deleted the duckdb branch February 13, 2025 05:32
@m-kuhn m-kuhn mentioned this pull request Feb 13, 2025
Draft
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-kuhn @MonicaLiu0311 @BillyONeal