Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tbb] Fix build for macOS with GCC #43742

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Jhuighuy
Copy link
Contributor

@Jhuighuy Jhuighuy commented Feb 10, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

The TBB build currently fails on macOS using GCC. Patch is also submitted upstream. Please see the upstream PR: uxlfoundation/oneTBB#1603

@Jhuighuy
Copy link
Contributor Author

@microsoft-github-policy-service agree

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project labels Feb 11, 2025
ports/tbb/fix-gcc-without-gas.patch Outdated Show resolved Hide resolved
ports/tbb/fix-gcc-without-gas.patch Outdated Show resolved Hide resolved
ports/tbb/fix-gcc-without-gas.patch Outdated Show resolved Hide resolved
@BillyONeal
Copy link
Member

BillyONeal commented Feb 14, 2025

The patch is now minimized and upstream has been notified for 30 days about this build issue, so this meets our criteria to merge now. Thanks for the fix, notifying upstream, and minimizing the patch!

@BillyONeal BillyONeal merged commit 6fbd577 into microsoft:master Feb 14, 2025
17 checks passed
@Jhuighuy Jhuighuy deleted the tbb-fix-macos-gcc branch February 14, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants