Target xUnit v3 #1117
Merged
Target xUnit v3 #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteo-prosperi
approved these changes
Jan 21, 2025
- `JoinableTaskFactory_IntegrationClientSideOnly_ManyConnections_UniqueTrackerLeadsToDeadlock` was deliberately testing a timeout condition but left the timed out main thread request pending potentially after the test completed.
This version doesn't take down the test runner for late-incoming UI thread requests
…emplate Specifically, this merges [429e76f from that repo](AArnott/Library.Template@429e76f).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library.Template already targets xUnit v3, but we reverted that for this repo while we waited for xunit.stafact to also support v3. Now that that's available, we can move forward.