Use approved npm feed for Dependabot - #806
Use approved npm feed for Dependabot#806Eduardo Villalpando Mello (edvilme) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e6cc7d12-a7f4-48b7-a8ea-c4532ce17ea2
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
|
Result: Verification detailsVerification: Isolated verification observed failures that were not classified as caused by this PR: Batched dependency and test discovery. Summary: The changed Dependabot YAML parsed and passed the repository's Prettier check. Ad-hoc assertions confirmed the approved registry settings, removal of the npm cooldown and `.npmrc`, and retention of the pip cooldown. Dependency setup completed successfully, but the initial discovery probe was limited by unavailable `HEAD^` history. Actual Dependabot OIDC authentication and feed access require external infrastructure and were not exercised, so verification is partial. Test runs: 3 passed, 1 failed
❌
|
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e6cc7d12-a7f4-48b7-a8ea-c4532ce17ea2
|
Result: Verification detailsVerification: Isolated verification observed failures that were not classified as caused by this PR: Ruby YAML structural validation. Summary: The targeted Prettier check passed, confirming `.github/dependabot.yml` is valid YAML and formatted correctly. Static assertions also confirmed the approved feed settings, npm association, cooldowns, and `.npmrc` removal. A Ruby-based parser check could not run because Ruby is unavailable, and the hosted Dependabot OIDC/feed authentication flow cannot be exercised in this environment. Verification is therefore partial. Test runs: 4 passed, 1 failed
❌
|
Summary - configure Dependabot npm updates to use the team-owned
Pylance_PublicPackagesAzure Artifacts feed - authenticate with Azure OIDC using the identity pattern established by microsoft/pyrx#9310 - retain the seven-day npm cooldown because@vscode/python-environmentsstill uses an explicit feed URL thatreplaces-basecannot redirect - retain the seven-day pip cooldown until an approved Python-feed path is confirmed - remove the project.npmrcthat forced Dependabot back to public npm ## Required infrastructure Do not removeno-mergeuntil the managed identity has feed access and a Dependabot federated credential for this repository. The credential must use issuerhttps://token.actions.msft.ghe.com, audienceapi://AzureADTokenExchange, and the exact repository subject emitted by Dependabot. The tenant and client IDs are identifiers, not secrets.