Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating connect timeout from 15 to 30 seconds #18593

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented Jan 24, 2025

Addresses #18521

Copy link

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 50.40% 50.53% $${\color{lightgreen} .13\% }$$
VSIX Size 12160 KB 12160 KB $${\color{lightgreen} 0 KB \space (0\%) }$$
Webview Bundle Size 3180 KB 3180 KB $${\color{lightgreen} 0 KB \space (0\%) }$$

Copy link
Member

@kburtram kburtram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, 15 sec is too slow for lower end Azure SQL DB SKU. Instead of lower this value, let's look at that the "total connect timeout" with all the reliable connection retry stuff. Maybe we can reduce the number of connect retry attempts of something like that. But yeah, messing with this value is a bit of a balancing act.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants