Pass keepAlive from custom agent #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If client uses a custom http or https agent, then pass its keepAlive flag in creation of PacProxyAgent.
|
@microsoft-github-policy-service agree company="Sourcegraph" |
chrmarti
requested changes
Apr 4, 2025
| @@ -0,0 +1,200 @@ | |||
| lockfileVersion: '9.0' | |||
There was a problem hiding this comment.
This file slipped in. Please remove it from the PR.
| @@ -158,8 +158,7 @@ describe('Direct client', function () { | |||
| }); | |||
| assert.ok(seen, 'Original agent not called!'); | |||
| }); | |||
| it.skip('should reuse socket with agent', async function () { | |||
| // Skipping due to https://github.com/microsoft/vscode/issues/228872. | |||
| it('should reuse socket with agent', async function () { | |||
| // https://github.com/microsoft/vscode/issues/173861 | |||
| const { resolveProxyWithRequest: resolveProxy } = vpa.createProxyResolver(directProxyAgentParams); | |||
| const patchedHttps: typeof https = { | |||
There was a problem hiding this comment.
The two requests below need a custom agent with keepAlive = true for the socket to be reused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, keepAlive flag is ignored in this issue. This causes to keepAlive to be false at agent level, which prevents connection re-use for all endpoints (see nodejs Agent). While some servers may not support keep-alive well, globally disabling the flag seems too broad of impact. It would be great if clients can decide on whether to use keepAlive (through request's keepAlive) instead.
This PR changes the logic of passing keepAlive flag. If client uses a custom http or https agent, then pass its keepAlive flag in creation of PacProxyAgent.