Skip to content

Get Notebook Uri from Cell Logic Fix #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 25, 2025
Merged

Get Notebook Uri from Cell Logic Fix #312

merged 8 commits into from
Apr 25, 2025
+46 −10

Conversation

eleanorjboyd
Copy link
Member

No description provided.

@eleanorjboyd eleanorjboyd added the bug Issue identified by VS Code Team member as probable bug label Apr 16, 2025
@eleanorjboyd eleanorjboyd self-assigned this Apr 16, 2025
@eleanorjboyd eleanorjboyd changed the title Notebook cell path fix Get Notebook Uri from Cell Logic Fix Apr 16, 2025
@eleanorjboyd eleanorjboyd marked this pull request as ready for review April 16, 2025 22:10
@vs-code-engineering VS Code Engineering
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 16, 2025
amunger
amunger previously approved these changes Apr 22, 2025
View reviewed changes
DonJayamanne
DonJayamanne requested changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid using fragment, this is done in core only because of the cell uri output scheme

DonJayamanne
DonJayamanne previously requested changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a few changes

@eleanorjboyd eleanorjboyd requested a review from amunger April 25, 2025 20:49
@eleanorjboyd eleanorjboyd enabled auto-merge (squash) April 25, 2025 20:55
@amunger amunger dismissed DonJayamanne’s stale review April 25, 2025 21:07

resolved comments

@eleanorjboyd eleanorjboyd merged commit 39e3225 into microsoft:main Apr 25, 2025
6 checks passed
@eleanorjboyd eleanorjboyd deleted the notebook-path-fix branch April 25, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amunger amunger amunger approved these changes

@DonJayamanne DonJayamanne DonJayamanne left review comments

@rebornix rebornix Awaiting requested review from rebornix

Assignees

@eleanorjboyd eleanorjboyd

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
April 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@eleanorjboyd @DonJayamanne @amunger