switch new project add to create method #336
Merged
+98
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleanorjboyd
commented
Apr 24, 2025
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
|
@karthiknadig question here is how we might know if findExisting project should be a project or not. Like if it has an env or not. Not sure how to tell this and build it into the logic |
|
We should remove the autofind projects feature and think about a better approach to it. What we have now was a demonstration of what you could do. |
karthiknadig
approved these changes
Apr 25, 2025
eleanorjboyd
added a commit
that referenced
this pull request
Apr 25, 2025
- renamed `addPythonProject` in src/features/envCommands.ts to `addPythonProjectCommand` (as it is only a command entry point) - moved responsibility so ProjectCreators are responsible for adding their created projects to the ProjectManager list - updated `addPythonProjectCommand` so it calls the selected ProjectCreator create method OR (if the resource param already a ProjectItem) just add it to the ProjectManager list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addPythonProjectin src/features/envCommands.ts toaddPythonProjectCommand(as it is only a command entry point)addPythonProjectCommandso it calls the selected ProjectCreator create method OR (if the resource param already a ProjectItem) just add it to the ProjectManager list