properly add to disposables

microsoft · May 23, 2024 · e270705 · e270705
1 parent 910783b
commit e270705
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/client/extensionActivation.ts b/src/client/extensionActivation.ts
@@ -109,7 +109,7 @@ export function activateFeatures(ext: ExtensionState, _components: Components):
 
     registerReplCommands(ext.disposables, interpreterService);
     registerReplExecuteOnEnter(ext.disposables, interpreterService);
-    registerReplExecuteOnShiftEnter();
+    registerReplExecuteOnShiftEnter(ext.disposables);
 }
 
 /// //////////////////////////

diff --git a/src/client/repl/replCommands.ts b/src/client/repl/replCommands.ts
@@ -193,10 +193,12 @@ export async function registerReplExecuteOnEnter(
     );
 }
 
-export async function registerReplExecuteOnShiftEnter(): Promise<void> {
-    commands.registerCommand(Commands.Exec_In_REPL_Shift_Enter, async () => {
-        await commands.executeCommand(Commands.Exec_In_REPL_Enter);
-    });
+export async function registerReplExecuteOnShiftEnter(disposables: Disposable[]): Promise<void> {
+    disposables.push(
+        commands.registerCommand(Commands.Exec_In_REPL_Shift_Enter, async () => {
+            await commands.executeCommand(Commands.Exec_In_REPL_Enter);
+        }),
+    );
 }
 
 function isMultiLineText(textEditor: TextEditor | undefined): boolean {