Skip to content

fix: use wrapper functions for easier testing #24941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

fix: use wrapper functions for easier testing #24941

merged 1 commit into from
Apr 2, 2025

Conversation

karthiknadig
Copy link
Member

Fixes #24426

@karthiknadig karthiknadig self-assigned this Mar 31, 2025
@karthiknadig karthiknadig added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Mar 31, 2025
@karthiknadig karthiknadig requested a review from anthonykim1 April 2, 2025 00:24
@karthiknadig karthiknadig added the skip tests Updates to tests unnecessary label Apr 2, 2025
@karthiknadig karthiknadig marked this pull request as ready for review April 2, 2025 00:24
@karthiknadig karthiknadig enabled auto-merge (squash) April 2, 2025 00:24
@vs-code-engineering VS Code Engineering
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 2, 2025
@karthiknadig karthiknadig merged commit 6a20c9c into microsoft:main Apr 2, 2025
47 of 50 checks passed
@karthiknadig karthiknadig deleted the issue-24426 branch April 2, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonykim1 anthonykim1 anthonykim1 approved these changes

Assignees

@karthiknadig karthiknadig

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. skip tests Updates to tests unnecessary
Projects
None yet
Milestone
April 2025
Development

Successfully merging this pull request may close these issues.

Refactor Native REPL code to avoid using wide scope VS Code namespace
2 participants
@karthiknadig @anthonykim1