Skip to content

force absolute path for coverage results #24948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

eleanorjboyd
Copy link
Member

fixes #24943

@eleanorjboyd eleanorjboyd self-assigned this Mar 31, 2025
@eleanorjboyd eleanorjboyd added the bug Issue identified by VS Code Team member as probable bug label Mar 31, 2025
@eleanorjboyd
Copy link
Member Author

@karthiknadig or @anthonykim1 any thoughts on how I could test this? I can't seem to force it to use relative paths when I run coverage so I could mock out maybe "is_absolute" but that seems like it would be more work than use since it might just cause flakiness

Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Mar 31, 2025
@anthonykim1
Copy link

anthonykim1 commented Apr 2, 2025

I would +1 on mocking "is_absolute"
I think @patch('pathlib.Path.is_absolute') is pretty much all you need assuming your tests will be on Python side.
Where patch is from unittest.mock.

@eleanorjboyd
Copy link
Member Author

discussed with Karthik, effort not worth the minimal reward here so keeping it with the skip tests label

@eleanorjboyd eleanorjboyd merged commit cd714bf into microsoft:main Apr 2, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't open the original file for coverage view
2 participants