remove ITestLogChannel #24954
remove ITestLogChannel #24954
Conversation
eleanorjboyd
added
the
debt
| @@ -79,7 +74,7 @@ export class UnittestTestDiscoveryAdapter implements ITestDiscoveryAdapter { | |||
| workspaceFolder: uri, | |||
| command, | |||
| cwd, | |||
| outChannel: this.outputChannel, | |||
| outChannel: this.logOutputChannel, | |||
There was a problem hiding this comment.
I have replaced ITestOutputChannel with ILogOutputChannel and still passing it through the the adapters to then add it to the spawn options here. Want to confirm this is necessary since I thought this output channel was used by spawn but not exactly sure how to confirm. @karthiknadig
There was a problem hiding this comment.
I think this looks fine. I am not really sure if this is even used internally anymore. But, need to follow the references here to understand better.
There was a problem hiding this comment.
for recording purposes- Karthik and I looked into execObservable and found no usage of the output channel and so we it entirely from the adapter
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
No description provided.