Test Coverage for older django versions #24968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleanorjboyd
requested review from
eleanorjboyd and
karthiknadig
and removed request for
eleanorjboyd
eleanorjboyd
added
bug
|
thanks for fixing those linting issues and things- will review today |
eleanorjboyd
approved these changes
Apr 7, 2025
karthiknadig
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue: #24199
@mcobalchinisoftfocus Discovered an issue with older django versions, which didn't have the main function in the manage.py
#24927 (comment)
I've fixed this issue by executing the code in manage.py with name set to main instead of relying on main function being there.
I've also adjusted the test, so that it would cover this case.