Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal suggest: Don't rely on isWindows in resolveResources #239411

Closed
Tyriar opened this issue Feb 1, 2025 · 0 comments · Fixed by #239540
Closed

Terminal suggest: Don't rely on isWindows in resolveResources #239411

Tyriar opened this issue Feb 1, 2025 · 0 comments · Fixed by #239540
Assignees
@Tyriar @meganrogge
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal-suggest
Milestone
February 2025

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 1, 2025

We depend on isWindows a few places in this file:

https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionService.ts#L10

Doing so has a couple of problems:

  • It's not totally correct and will fall over when mac connects to a Windows machine for example.
  • It's not possible to test against all OS' on a single OS.

If we pass in isWindows from the extension host request, this will allow us to do that in tests too.
@Tyriar Tyriar added debt Code quality issues terminal-suggest labels Feb 1, 2025
@Tyriar Tyriar added this to the February 2025 milestone Feb 1, 2025
meganrogge added a commit that referenced this issue Feb 3, 2025
@meganrogge
fix #239411

Verified

This commit was signed with the committer’s verified signature.
meganrogge Megan Rogge
GPG key ID: B8E497F5C2C8EDE8
Verified
Learn about vigilant mode
5cee138
meganrogge added a commit that referenced this issue Feb 3, 2025
@meganrogge
fix #239411

Verified

This commit was signed with the committer’s verified signature.
meganrogge Megan Rogge
GPG key ID: B8E497F5C2C8EDE8
Verified
Learn about vigilant mode
24ff56b
@meganrogge meganrogge mentioned this issue Feb 3, 2025
Merged
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 6, 2025
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal-suggest
Projects
None yet
Milestone
February 2025
Development

Successfully merging a pull request may close this issue.

define pathSeparator in ext host for terminal suggest microsoft/vscode
2 participants
@Tyriar @meganrogge