What font size are you using? With that font size, how does it look in the editor?

I have editor font family "Jetbrains Mono" and font size 16, but I'm suprised it would affect terminal suggest given terminal has its own font family and size (which I haven't changed)

  "editor.fontFamily": "JetBrains Mono, Menlo, Monaco, 'Courier New', monospace",
  "editor.fontLigatures": true,
  "editor.fontSize": 16,

My editor suggest:

It seems terminal suggest isn't passed correct font info.

We use editor's font family, size, etc. for this to be consistent with the editor's suggest widget. We do not use the terminal's values for these.

I'll see what's going on for your particular setup. The one in the editor and terminal should look the same.

With fontSize: 16, upon inspection, the editor and terminal suggest items have the same height and thus look the same amount of crammed.

When using a different font, I do see a difference though.

My guess is the editor does something special here

maybe related to monospace fonts

We use editor's font family, size, etc. for this to be consistent with the editor's suggest widget. We do not use the terminal's values for these.

it's very surprising that all text in terminal uses one font and suggestions would use another (if user has configured different font for terminal & editor, which was my case)

@ulugbekna wouldn't it also be surprising that 2 auto complete widgets would look different in the same application depending on context?

@Tyriar IMHO I wouldn't have noticed the two suggests being different, but I did notice difference between fonts in my terminal, especially because I use different font sizes

@Tyriar @meganrogge Since I'm now seeing suggest in terminal quite often compared to never before, I was wondering if this's a new feature for this iteration. This issue seems quite bad, so maybe it should prevent terminal suggest being on by default? Or maybe @jrieken could help with figuring out how to adjust the line height so the suggest is displayed correctly.

@ulugbekna it's currently experimental and off by default, I'm guessing we'll promote to preview for Feb and eventually the hope is to enable it by default.

I can repro with fontSize 16:

Looks like the editor changes the item/line height:

It was my idea to use the editor font, maybe that was wrong, I'm not sure. I always try keep them in sync.

I think you've convinced me, @meganrogge let's just use the terminal text config here and fix up the line height. It makes sense considering that when you complete it should appear and look the same as it looked in the suggest widget.