use terminal font for terminal suggest #239543
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Feb 3, 2025
src/vs/workbench/services/suggest/browser/simpleSuggestWidget.ts
Outdated
Show resolved
Hide resolved
Tyriar
reviewed
Feb 3, 2025
Comment on lines
+385
to
+390
| if (lineHeight <= 1) { | ||
| // Scale so icon shows by default | ||
| lineHeight = fontSize < 16 ? Math.ceil(fontSize * 1.5) : fontSize; | ||
| } else if (lineHeight <= 8) { | ||
| lineHeight = fontSize * lineHeight; | ||
| } |
There was a problem hiding this comment.
Is this how the editor was scaling line height? We want large fontSizes to look the same in editor and terminal
There was a problem hiding this comment.
no, line height looks a little different. i'll have to see what they do
auto-merge was automatically disabled
February 3, 2025 23:13
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #239095
to do: test font family