-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Implement platform specific URL format #238890
base: main
Are you sure you want to change the base?
Conversation
Converting to draft as I see that now I need to also update Will need to find out how to do that first so I can make the necessary edits and update the PR again. |
command: npm run update-build-ts-version
@microsoft-github-policy-service agree |
Apologies @818Nawaf for delays but I had to see what is the best native way to update the javascript files under Eventually found the command: npm run update-build-ts-version This updated Could you please re-approve the PR? Thank you! |
Fixes #238886
TLDR: Test with below steps
product.json
for multi-platform extensions (e.g.ms-python.debugpy
)npm run gulp compile-extensions-build
Please see the description in the related issue for how to test this in the linked issue.
The issue was that marketplace links required a URL query parameter for multi-platform extensions or it fails with HTTP 404 status (e.g.
?targetPlatform=linux-x64
).This was missing in the current implementation for the
build/lib/extensions.ts::fromMarketplace
function.Fixed this by checking the
platforms
list from theIExtensionDefinition
interface (as used inproduct.json
). If thisplatforms
key is specified and current platform is in the provided list then add the necessary URL query parameter for the marketplace service.This was tested by adding the below platforms in the
product.json
file:Related: #180525 / PR: #182072