Add to new source format and the mandatory signed-by

[bhack]

fixes #238697

[Nichebiche]

fixes #238697

[Nichebiche]

[wcbing]

Your method uses the modernize-sources subcommand to check, but several versions will prompt without this subcommand. So, I think it's better to determine it by the apt version number.

In fact, even Debian and Ubuntu versions that are not EOL now support DEB822 sources, so perhaps there's no need for the check.

---

You also need to modify the if-elif blocks on here to facilitate migration from old repository, or else they will conflict.

[wcbing]

A digression: If possible, squash your formatting changes into the earlier commits. The current commit history doesn't look very clean. 👀

[bhack]

but several versions will prompt without this subcommand

I have not bisected this what is the starting point of this notification?

In my experience It seems to me very connected to modernize introduction.

[wcbing]

The missing Signed-By warning and migration consideration started with version 2.9.24, while the modernize-sources subcommand was added in 2.9.26.

In fact, even Debian and Ubuntu versions that are not EOL now support DEB822 sources, so perhaps there's no need for the check.

Do you think this is right?

[bhack]

I suppose it was introduced since APT 1.1

[bhack]

I will wait for the vscode team's official feedback about what kind of behaviour we want to adopt.

[wcbing]

You did not change the gpg key location or embed it in the sources file as I mentioned.

[bhack]

You did not change the gpg key location or embed it in the sources file as I mentioned.

Cause I think this will require to handle also the removal case of the existing key.

So I think this could be introduced eventually in another PR.