Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving away from execCommand for pasting #239617

Closed
wants to merge 7 commits into from
Closed

Moving away from execCommand for pasting #239617

wants to merge 7 commits into from

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Feb 4, 2025

move away from execCommand for pasting

Points to discuss:

  • Paste from webcontents returns void, not boolean. Is the operation always successful? The paste from dom, returns a boolean.
  • Not sure when the second branch is executed. It is apparently executed when the editor does not have focus.

@aiday-mar aiday-mar self-assigned this Feb 4, 2025
@deepak1556
Copy link
Collaborator

deepak1556 commented Feb 5, 2025

FYI @aiday-mar the issue #239228 is primarily about the paste command that will be soon removed from the desktop runtime. Cut and Copy will continue to behave as they do in browsers today which are still supported.

Maybe we can split the PR to focus on the paste command ?

@aiday-mar
Copy link
Contributor Author

Hi Deepak, oh right I thought we would be moving generally away from the execCommand. I'll see how/if I can make a change only to the past logic

@aiday-mar aiday-mar changed the title Moving away from execCommand for copying/pasting/cutting Moving away from execCommand for pasting Feb 6, 2025
@aiday-mar aiday-mar closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants