Extension detail content escapes container #240134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not think this is the right fix. I believe the fix would be to adjust the height of the extension editor so that it is not shown on top. |
|
@sandy081 If my understanding is correct, the height of the overlay webview follows the height of the extension editor, the latter is taking 1px more than it should be. I have reduced the height of the extension editor by 1px. Let me know if there is anything else I need to change. |
sandy081
approved these changes
Feb 11, 2025
Tyriar
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231439
Applies z-index on the bottom panel container, so that it is on top of the extension detail scrollbar.