Integrate with fig's generator code #240135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
dismissed
meganrogge’s stale review
The merge-base changed after approval.
meganrogge
previously approved these changes
Feb 10, 2025
meganrogge
previously approved these changes
Feb 10, 2025
|
Tests failing for valid reasons |
meganrogge
reviewed
Feb 10, 2025
| for (const command of availableCommands) { | ||
| if (!labels.has(command.label)) { | ||
| items.push(createCompletionItem(terminalContext.cursorPosition, prefix, command, command.detail)); | ||
| } else { |
There was a problem hiding this comment.
I think we want it how it was before? Otherwise, it's possible that result had no items, neither files nor folders were requested, and we won't change that.
There was a problem hiding this comment.
Good call, that's why the tests failed too 👍
|
The cause: 015b23f |
meganrogge
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings in the majority of dealing with script and custom generators from https://github.com/aws/amazon-q-developer-cli/tree/main/packages/autocomplete. Template generators are out of scope for this PR. It also features a big refactor that pulls all dealing with the
fig/folder intofig/figInterface.tsto better segment the "outside" code from the terminal-suggest extension.Example of script generator:
Example of custom generator (showing local branches since -r isn't there):
Limitations:
npmwon't work. We'll need some special handling to get the actual path on Windows I think Terminal suggest: fig generator completions often complain about the executable not existing #240139Part of #239519
Fixes #240131