Merged
Conversation
dotnet.config is no longer suppported way of configuring mtp, replace it with global.json
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
Failure was observed locally here: #15450 And I was not sure why I don't also see it in CI build for the same change. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes release-mode skipping for stack overflow acceptance tests and makes the assertions less dependent on exact line endings / additional crash details.
Changes:
- Removed
Assert.Inconclusiveguard that skipped stack overflow tests in Release builds. - Updated stack overflow error assertions to be pattern-based and to assert a single error entry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test/Microsoft.TestPlatform.Acceptance.IntegrationTests/TranslationLayerTests/RunTests.cs | Stops skipping in Release and changes error assertion to pattern-match a single reported error. |
| test/Microsoft.TestPlatform.Acceptance.IntegrationTests/ExecutionTests.cs | Stops skipping the console/diag-log stack overflow test in Release builds. |
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/TranslationLayerTests/RunTests.cs
Show resolved
Hide resolved
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/TranslationLayerTests/RunTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/TranslationLayerTests/RunTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/TranslationLayerTests/RunTests.cs
Outdated
Show resolved
Hide resolved
…ationLayerTests/RunTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/TranslationLayerTests/RunTests.cs
Show resolved
Hide resolved
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/TranslationLayerTests/RunTests.cs
Show resolved
Hide resolved
Youssef1313
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stack overflow tests were skipping themselves in release mode, but that is unnecessary since we are killing the process by allocating more space than the stack has, so it will always stack overflow, no matter if any tail call optimization is applied or not.
Before the change the tests were always failing in Debug mode, because the returned error from NET contains also stack trace, but we just check for exact string in a collection of strings. We run tests as Release in CI, which is why we don't see the failures in CI.