Conversation
There was a problem hiding this comment.
Pull request overview
Updates the test/compatibility matrix by bumping framework/tooling versions and adjusting MSTest execution settings in test assets.
Changes:
- Updated NUnit and MSTest version properties used by compatibility/test-asset builds.
- Updated VSTest console version properties used for compatibility testing.
- Added MSTest assembly-level parallelization configuration to two test asset projects.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/TestAssets/MSTestProject2/UnitTest1.cs | Adds assembly-level MSTest parallelization configuration to influence test execution behavior. |
| test/TestAssets/MSTestProject1/UnitTest1.cs | Adds assembly-level MSTest parallelization configuration to influence test execution behavior. |
| eng/Versions.props | Bumps NUnit/MSTest/VSTest versions used by build/test compatibility matrices. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| // Class level just because we want the tests to run in predictable order. | ||
| [assembly: Parallelize(Scope = ExecutionScope.ClassLevel, Workers = 0)] |
There was a problem hiding this comment.
Workers = 0 in MSTest does not disable parallelization (it typically means “use default worker count”), which conflicts with the comment about predictable order and can still lead to non-deterministic execution. If the goal is deterministic execution, use [assembly: DoNotParallelize] or set Workers = 1 (and update the comment accordingly)."
| // Class level just because we want the tests to run in predictable order. | |
| [assembly: Parallelize(Scope = ExecutionScope.ClassLevel, Workers = 0)] | |
| // Use a single worker so tests run in a predictable order. | |
| [assembly: Parallelize(Scope = ExecutionScope.ClassLevel, Workers = 1)] |
|
needs #15480 where we are using only recent vstest.console to run compatibility checks on vstest.console, this avoids needing the old runtimes which we remove here. (testhost does not need the runtime, because we pass runtime.config.json of the project, if someone is using netcoreapp2.1 that is their fault and they should update from this unsupported version of .NET) |
|
The other errors I don't know yet. Need to merge stuff first, too many moving parts right now. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description
Update versions. Look at how to do this automatically later.
Related issue
Fix #15475