Fix PassingNoArguments test: disable --diag to preserve help output#15583
Merged
nohwnd merged 1 commit intomicrosoft:mainfrom Mar 26, 2026
Merged
Fix PassingNoArguments test: disable --diag to preserve help output#15583nohwnd merged 1 commit intomicrosoft:mainfrom
nohwnd merged 1 commit intomicrosoft:mainfrom
Conversation
microsoft#15572 added automatic --diag to InvokeVsTest (default true). This test passes no arguments to vstest.console and checks for help text, but --diag changes the output, truncating the help message. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates an acceptance test to avoid automatic --diag invocation so that vstest.console help output remains stable and the “no arguments prints help” assertion passes.
Changes:
- Disable diagnostics collection in
InvokeVsTestfor the “no args” help-output test. - Add an inline comment explaining why diagnostics are disabled for this scenario.
| SetTestEnvironment(_testEnvironment, runnerInfo); | ||
|
|
||
| InvokeVsTest(null); | ||
| // Don't add --diag, it changes the output and prevents help from showing. |
There was a problem hiding this comment.
The comment conflicts with the PR description: --diag changes the output and truncates/changes the help text, but it doesn’t literally prevent help from showing (the test still asserts help content is present). Update the wording to match the actual failure mode (e.g., ‘changes/truncates the help output’) to avoid misleading future readers.
Suggested change
| // Don't add --diag, it changes the output and prevents help from showing. | |
| // Don't add --diag; it changes/truncates the output and would alter the help text this test asserts on. |
This was referenced Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#15572 added automatic --diag\ to \InvokeVsTest\ (default \ rue). The \PassingNoArgumentsToVsTestConsoleShouldPrintHelpMessage\ test passes no arguments to vstest.console and checks for help text, but --diag\ changes the output and truncates the help message.
Fix: pass \collectDiagnostics: false\ to preserve the expected output.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com