Skip VideoRecorder test on CI due to access denied errors#15587
Skip VideoRecorder test on CI due to access denied errors#15587nohwnd merged 1 commit intomicrosoft:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Skips the VideoRecorder acceptance test on CI to work around “access denied” failures during video recording (linked to #15586).
Changes:
- Adds an early
Assert.Inconclusive(...)guard intended to skip the test on CI.
| // Workaround for #15586 — video recording fails with access denied on the official CI pipeline. | ||
| if (Environment.GetEnvironmentVariable("_RunAsInternal") == "True") | ||
| { | ||
| Assert.Inconclusive("Video recorder test is skipped on the official pipeline due to access denied errors. See #15586."); | ||
| } |
There was a problem hiding this comment.
The PR description says the test should be skipped when TF_BUILD is set (matching BlameDataCollectorTests), but the code checks _RunAsInternal == \"True\". This looks inconsistent and may fail to skip on the official CI (or skip in the wrong environment). Either update the condition to use TF_BUILD (or the same predicate as BlameDataCollectorTests), or update the PR description/comment to reflect the actual gating signal.
| public void VideoRecorderDataCollectorShouldRecordVideoWithRunSettings(RunnerInfo runnerInfo) | ||
| { | ||
| // Workaround for #15586 — video recording fails with access denied on the official CI pipeline. | ||
| if (Environment.GetEnvironmentVariable("_RunAsInternal") == "True") |
There was a problem hiding this comment.
Comparing environment variables with a case-sensitive literal can be brittle across environments/agents. Prefer a case-insensitive comparison (e.g., string.Equals(..., StringComparison.OrdinalIgnoreCase)) or a non-empty check if the variable is treated as a boolean flag.
Detect official pipeline via _RunAsInternal env variable (already set in azure-pipelines-official.yml). Only skips on the specific pipeline where the issue occurs, not on all CI or local runs. Workaround for microsoft#15586 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Workaround for #15586 — video recording test fails with access denied on the official CI pipeline. Skips with \Assert.Inconclusive\ when \TF_BUILD\ is set, matching the existing pattern from \BlameDataCollectorTests.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com