Skip to content

Mark PathConverter tests as Windows-only#15617

Merged
nohwnd merged 1 commit intomicrosoft:mainfrom
nohwnd:fix/pathconverter-tests-windows-only
Mar 30, 2026
Merged

Mark PathConverter tests as Windows-only#15617
nohwnd merged 1 commit intomicrosoft:mainfrom
nohwnd:fix/pathconverter-tests-windows-only

Conversation

@nohwnd
Copy link
Copy Markdown
Member

@nohwnd nohwnd commented Mar 30, 2026

Problem

PathConverter regression tests fail on Linux because they use hardcoded Windows backslash paths (\C:\Remote\TestDir). On Linux, \Path.DirectorySeparatorChar\ is /\ and \GetFullPath\ doesn't normalize Windows-style paths, so the path replacement never matches.

Fix

Add [TestCategory("Windows")]\ to both \PathConverterRegressionTests\ and \PathConverterDiscoveryCriteriaRegressionTests. PathConverter is a UWP deployment feature that only applies on Windows.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

PathConverter is a UWP deployment feature using Windows paths. The tests
use hardcoded backslash paths that fail on Linux because
Path.DirectorySeparatorChar is '/' and GetFullPath doesn't normalize
Windows-style paths.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 30, 2026 16:02
@nohwnd nohwnd merged commit b4371c1 into microsoft:main Mar 30, 2026
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant