Convert cpprestsdk to WIL exception for better handling #5188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
previously approved these changes
Feb 6, 2025
| @@ -233,4 +241,9 @@ namespace AppInstaller::Http | |||
|
|
|||
| return response.extract_json().get(); | |||
| } | |||
|
|
|||
| [[noreturn]] void HttpClientHelper::RethrowAsWilException(web::http::http_exception& exception) | |||
yao-msft
reviewed
Feb 7, 2025
| @@ -115,6 +115,10 @@ namespace AppInstaller::Http | |||
|
|
|||
| return ValidateAndExtractResponse(httpResponse); | |||
| } | |||
| catch (web::http::http_exception& exception) | |||
There was a problem hiding this comment.
nit: the 2 catches here and below could be const too
There was a problem hiding this comment.
Putting const on the catch is like putting const on a by-value parameter. It is only there to stop you from changing something you have decided you don't want to change accidentally. I will leave this one.
yao-msft
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
To better expose the underlying result code, convert the
http_exceptionto aResultExceptionso that the HRESULT can be properly extracted.Validation
Using the PowerShell module and interfering with my connection, I was able to see that the connect result's extended error was originally
8007023E, but changed to the appropriate80072EE2with the change.Microsoft Reviewers: Open in CodeFlow