Fix path search #135
Open
Fix path search #135
+86
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryfu-msft
suggested changes
Dec 10, 2024
microsoft-github-policy-service
bot
added
the
Changes-Requested
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
Gijsreyn
force-pushed
the
fix-vscode-search-path
branch
from
7cc1632 to
d411df7
Compare
microsoft-github-policy-service
bot
removed
Changes-Requested
|
Thanks for the comments @ryfu-msft . I have rewritten the logic and grabbed most of the old stuff from you. Looking at the code from: https://github.com/desktop/desktop/blob/development/app/src/lib/editors/win32.ts, I included the WOW6432Node path as well. Let me know what you think. On a 64-bit system, I'm getting this:
|
ryfu-msft
suggested changes
Dec 20, 2024
microsoft-github-policy-service
bot
added
Changes-Requested
added 2 commits
December 21, 2024 06:14
…winget-dsc into fix-vscode-search-path
microsoft-github-policy-service
bot
removed
Changes-Requested
|
Sorry to bug you both @denelon or @stephengillie . Still waiting for this one to get pulled in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #105
Microsoft Reviewers: Open in CodeFlow