Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation navigation #817

Merged
merged 4 commits into from
Jul 2, 2019
Merged

Update documentation navigation #817

merged 4 commits into from
Jul 2, 2019

Conversation

AlexB52
Copy link
Contributor

@AlexB52 AlexB52 commented Jul 2, 2019

Fixes #818

Problems:

  • Looking at the source all basics & advanced pages are available through the documentation navigation except "Template Engine Options".
  • Also some locales are unused in the navigation.

Here is a PR that:

  • Removes the unused locales
  • Moves the "Template Engine Options" pages from basic to advanced folder
  • Displays the "Template Engine Options" in the advanced section of the documentation
  • Add the relevant Netlify redirects to the template-engine-options page

This is ok if the PR is not accepted. I just wanted to contribute to some extent to the project and create discussion around that "hidden" page.

Considerations

I tried to merge "Templating Language" and "Template Engine Options" into one page but it feels off to appear in the basics section. I decided to move it to the advanced section instead.

What do you think?

@tdreyno tdreyno merged commit c2c8ba0 into middleman:master Jul 2, 2019
@tdreyno
Copy link
Member

tdreyno commented Jul 2, 2019

Thanks!

@AlexB52 AlexB52 deleted the update_documentation_navigation branch July 2, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template Engine Options page
2 participants