Deferred.getInvocationInfo.proceedToAfterExecSpinlocks error logging#7
Open
wulfsolter wants to merge 1 commit intomikermcneil:masterfrom
Open
Deferred.getInvocationInfo.proceedToAfterExecSpinlocks error logging#7wulfsolter wants to merge 1 commit intomikermcneil:masterfrom
wulfsolter wants to merge 1 commit intomikermcneil:masterfrom
Conversation
…rg regardless of having an omen, not print errCbArg if not present
|
@mikermcneil Can we please look at this, this is a problem with us also. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside a vanilla
function()method (as opposed to async/promise etc) in a SailsJS service attempting to access the property of an undefined results in an error that has not triggered creation of an omen, so only getting logging ofThis PR extends how
Deferred.getInvocationInfo.proceedToAfterExecSpinlockshandles passed params - to log out the original error even if no omen exists yet, and to also only log errCbArg if it actually exists.@mikermcneil I should've done this originally in #6 :)