Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top icon in MdButton #117

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Top icon in MdButton #117

merged 2 commits into from
Apr 16, 2024

Conversation

kajsaeggum
Copy link
Contributor

Describe your changes

Added option on MdButton for a top-icon, to implement the following design:
image

Also added a gallery story to easily see all available icons in one screen:
image

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@kajsaeggum kajsaeggum requested a review from a team as a code owner April 16, 2024 10:40
@github-actions GitHub Actions
Copy link
Contributor

Please set a versioning label of either major, minor, or patch to the pull request.

aurorascharff
aurorascharff approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@aurorascharff aurorascharff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tror dette er all good, super nice med alle-ikon-viewet!! Det trengte vi.

@kajsaeggum kajsaeggum merged commit 2e09858 into main Apr 16, 2024
3 checks passed
@kajsaeggum kajsaeggum deleted the feature/MdButton_TopIcon branch April 16, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurorascharff aurorascharff aurorascharff approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kajsaeggum @aurorascharff @crolsson