Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tertiary-theme to MdButton #126

Merged
merged 3 commits into from
May 30, 2024
Merged

Add tertiary-theme to MdButton #126

merged 3 commits into from
May 30, 2024

Conversation

aurorascharff
Copy link
Contributor

@aurorascharff aurorascharff commented May 30, 2024

Describe your changes

Implement tertiary button.
Design has been approved and added to the design system Figma by our projects' designer.

Animation

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@aurorascharff aurorascharff requested a review from a team as a code owner May 30, 2024 08:14
Copy link
Contributor

Please set a versioning label of either major, minor, or patch to the pull request.

@aurorascharff aurorascharff changed the title Add tertiary-button to MdButton Add tertiary-theme to MdButton May 30, 2024
Copy link

@thomaslarsson thomaslarsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. If possible, change the wrapper bg color in the demo. It is slightly confusing that the button looks like a "link style button" on white backgrounds right now. (Like in the attached video) This will make it more obvious that the button is white instead of transparent. (Link style)

@aurorascharff
Copy link
Contributor Author

aurorascharff commented May 30, 2024

Approved. If possible, change the wrapper bg color in the demo. It is slightly confusing that the button looks like a "link style button" on white backgrounds right now. (Like in the attached video) This will make it more obvious that the button is white instead of transparent. (Link style)

Det er dette som har blitt bestemt av designer. Det er visst en vanlig funksjonalitet. Selvom den ser ut som en "link". Men den er altså ikke det. Edit: Her var det snakk om demoen/storybook. Edit: Snakket med Thomas og knappen skulle være gjennomsiktig, ikke hvit!

Jeg har tenkt litt på at vi ikke tillater <a / <button differansiering i button, sånn som jeg ahr lagt til i MdLink og MdTile. Altså at hvis man bruker href så blir elementet en a-tag. Men det får vi ta som neste steg etter denne er blitt en vanlig knapp.

Copy link

@thomaslarsson thomaslarsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godkjent ref siste diskusjonsrunde.

@aurorascharff aurorascharff merged commit d55583e into main May 30, 2024
3 checks passed
@aurorascharff aurorascharff deleted the tertiary-button branch May 30, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants