-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tertiary-theme to MdButton #126
Conversation
Please set a versioning label of either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. If possible, change the wrapper bg color in the demo. It is slightly confusing that the button looks like a "link style button" on white backgrounds right now. (Like in the attached video) This will make it more obvious that the button is white instead of transparent. (Link style)
Det er dette som har blitt bestemt av designer. Det er visst en vanlig funksjonalitet. Selvom den ser ut som en "link". Men den er altså ikke det. Edit: Her var det snakk om demoen/storybook. Edit: Snakket med Thomas og knappen skulle være gjennomsiktig, ikke hvit! Jeg har tenkt litt på at vi ikke tillater <a / <button differansiering i button, sånn som jeg ahr lagt til i MdLink og MdTile. Altså at hvis man bruker href så blir elementet en a-tag. Men det får vi ta som neste steg etter denne er blitt en vanlig knapp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Godkjent ref siste diskusjonsrunde.
Describe your changes
Implement tertiary button.
Design has been approved and added to the design system Figma by our projects' designer.
Checklist before requesting a review
major
,minor
orpatch
)stories
-folder?packages/react/index.tsx
?packages/css/index.css
?