Add MdRadioButton component #127
Conversation
|
Please set a versioning label of either |
| } | ||
|
|
||
| /* Disabled */ | ||
| .md-radiobutton--disabled:hover { |
There was a problem hiding this comment.
Keep in mind :disabled is a selector. This works with the disabled prop on an element. Any reason not to use this?
There was a problem hiding this comment.
Copy paste css from existing component. Avoiding refactoring unrelated things and follow existing structure.
There was a problem hiding this comment.
E.g prøver å ikke henge meg opp i måten det har blitt gjort tidligere - isåfall burde det refaktorers overalt det er relevant. Men skal se på det.
| const classNames = classnames( | ||
| 'md-radiobutton', | ||
| { | ||
| 'md-radiobutton--disabled': !!disabled, |
There was a problem hiding this comment.
Consider changing this to an element property and style via :disabled instead
There was a problem hiding this comment.
Evt gjøre disse tingene i ny PR så man slipper å lage ulik konvenskjon på tvers av komponenter. Eks. radiobutton bruker :disabled mens radiogroup bruker --disabled. Skal se på det.
Describe your changes
Similarly to MdCheckbox and MdCheckboxGroup, MdRadioGroup needed a "single" component option, to allow for more flexibility.
In addition, clean up some old story-documentation code to follow one standard.
Example of a situation where single radiobuttons is useful (keep in mind to add your own a11y when using these solo):
Checklist before requesting a review
major,minororpatch)stories-folder?packages/react/index.tsx?packages/css/index.css?