Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additonal margin between MdButton content and left/right icons #143

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Add additonal margin between MdButton content and left/right icons #143

merged 2 commits into from
Jun 25, 2024

Conversation

aurorascharff
Copy link
Contributor

@aurorascharff aurorascharff commented Jun 25, 2024 •
edited
Loading

Describe your changes

MdButton margin between the left/right icons did not correspond to the design system specification. Fixed.

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@github-actions GitHub Actions
Copy link
Contributor

Please set a versioning label of either major, minor, or patch to the pull request.

@aurorascharff aurorascharff changed the title Add additonal margin between MdButton content and left/right icons pe… Add additonal margin between MdButton content and left/right icons Jun 25, 2024
@aurorascharff aurorascharff marked this pull request as ready for review June 25, 2024 11:50
@aurorascharff aurorascharff requested a review from a team as a code owner June 25, 2024 11:50
kajsaeggum
kajsaeggum reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@kajsaeggum kajsaeggum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potensielt en del impact på dette alle steder det brukes, så lurer på om patch er litt for lav nivå..

@aurorascharff aurorascharff added minor and removed patch labels Jun 25, 2024
@aurorascharff
Copy link
Contributor Author

Potensielt en del impact på dette alle steder det brukes, så lurer på om patch er litt for lav nivå..

Godt poeng. Designsystemet bruker denne paddingen. Hva tenker du jeg burde gjøre med denne?

@kajsaeggum
Copy link
Contributor

kajsaeggum commented Jun 25, 2024 •
edited
Loading

Potensielt en del impact på dette alle steder det brukes, så lurer på om patch er litt for lav nivå..

Godt poeng. Designsystemet bruker denne paddingen. Hva tenker du jeg burde gjøre med denne?

Dette komponentbiblioteket må jo følge designsystemet så det er vel bare å kjøre på tenker jeg :) Minor høres litt bedre ut dog, siden man da ikke bare kan anta at alt fungerer og ser helt likt ut etter en oppdatering, som ved Patch.

@aurorascharff
Copy link
Contributor Author

Potensielt en del impact på dette alle steder det brukes, så lurer på om patch er litt for lav nivå..

Godt poeng. Designsystemet bruker denne paddingen. Hva tenker du jeg burde gjøre med denne?

Dette komponentbiblioteket må jo følge designsystemet så det er vel bare å kjøre på tenker jeg :) Minor høres litt bedre ut dog, siden man da ikke bare kan anta at alt fungerer og ser helt likt ut etter en oppdatering, som ved Patch.

Ok, takk for tilbakemelding. Enig!

@aurorascharff aurorascharff merged commit f67837e into main Jun 25, 2024
3 checks passed
@aurorascharff aurorascharff deleted the button-icon-padding branch June 25, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kajsaeggum kajsaeggum kajsaeggum approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aurorascharff @kajsaeggum