Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fullwidth option to MdTile #167

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Add fullwidth option to MdTile #167

merged 1 commit into from
Sep 11, 2024

Conversation

aurorascharff
Copy link
Contributor

@aurorascharff aurorascharff commented Sep 11, 2024 •
edited
Loading

Describe your changes

Add fullWidth option to MdTile. This is useful for i.e mobile views and can be combined with mode="small".

image

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@github-actions GitHub Actions
Copy link
Contributor

Please set a versioning label of either major, minor, or patch to the pull request.

aurorascharff
aurorascharff commented Sep 11, 2024
View reviewed changes
packages/css/src/tile/tile.css
@@ -13,20 +13,28 @@
gap: 1.5em;
text-align: start;
width: 440px;
min-width: 440px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette er for å hindre at tilen i "button"-type blir flexet ned til mindre enn 440px.

@aurorascharff aurorascharff marked this pull request as ready for review September 11, 2024 11:57
@aurorascharff aurorascharff requested a review from a team as a code owner September 11, 2024 11:57
@aurorascharff aurorascharff merged commit f8b31ea into main Sep 11, 2024
5 checks passed
@aurorascharff aurorascharff deleted the tile-fullwidth branch September 11, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kajsaeggum kajsaeggum kajsaeggum approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aurorascharff @kajsaeggum