Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: When escaping inside an autocomplete, the displayvalue was shown while input was focused #179

Merged
merged 6 commits into from
Oct 4, 2024
Merged

fix: When escaping inside an autocomplete, the displayvalue was shown while input was focused #179

merged 6 commits into from
Oct 4, 2024

Conversation

aurorascharff
Copy link
Contributor

@aurorascharff aurorascharff commented Oct 3, 2024 •
edited
Loading

Describe your changes

When closing an autocomplete with enter or escape, the displayvalue was shown while input being focused. The value would not be editable and behavior was weird. Remove the autofocus for the autocomplete on close. In the future, hopefully the bug can be fixed in a better way.

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Please set a versioning label of either major, minor, or patch to the pull request.

@aurorascharff aurorascharff changed the title fix: When espacing inside an autocomplete, the displayvalue was shown while input being focused fix: When escaping inside an autocomplete, the displayvalue was shown while input being focused Oct 3, 2024
@aurorascharff aurorascharff changed the title fix: When escaping inside an autocomplete, the displayvalue was shown while input being focused fix: When escaping inside an autocomplete, the displayvalue was shown while input was focused Oct 4, 2024
@aurorascharff aurorascharff marked this pull request as ready for review October 4, 2024 08:00
@aurorascharff aurorascharff requested a review from a team as a code owner October 4, 2024 08:00
@aurorascharff aurorascharff merged commit c3d8420 into main Oct 4, 2024
3 checks passed
@aurorascharff aurorascharff deleted the fix-autocomplete-focus branch October 4, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kajsaeggum kajsaeggum kajsaeggum approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aurorascharff @kajsaeggum