-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Px/em to rem #187
Px/em to rem #187
Conversation
Update all scss-files to use rem (where appropriate)
Please set a versioning label of either |
Testet branchen i eget prosjekt som beskrevet her: https://github.com/miljodir/md-components/blob/main/README.md#teste-endringer-i-eget-prosjekt Ting ser likt ut som før for min del :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Koden ser bra ut :)
@kajsaeggum Det skal jeg få kikka på! |
after setting border-box on all elements, we can remove border-compensation for widths
Update all css-files to use rem (where appropriate)
Added border-box to all elements
Describe your changes
box-sizing: border-box;
on all elements, unless set explicitlyChecklist before requesting a review
major
,minor
orpatch
)stories
-folder?packages/react/index.tsx
?packages/css/index.css
?