Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup and update readmes #91

Merged
merged 1 commit into from
Jan 26, 2024
Merged

cleanup and update readmes #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,8 @@ Klon dette repoet og gjør følgende:
npm install
npm run storybook
```

## Labels på pull-requests

Alle pull requests krever nå at de legges på en label (`major`, `minor` eller `patch`). Disse vil brukes for å bumpe pakke versjonene før de publiseres til npm.
Labels er fortsatt påkrevd selv om pakkene ikke berøres (f.eks. bare storybook endringer), men dette vil heller ikke kjøre workflowene som bumper pakker og dytter til npm.
2 changes: 0 additions & 2 deletions packages/css/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,3 @@ const MyComponent = () => {
**For HTML structure for each component, see the README.md for each css-file, located in /src, or the `Docs`-section in the [Storybook](https://miljodir.github.io/md-components/) for each component. This must be followed if stylesheets are used as standalone, without React components.**

_For React components, see [@miljodirektoratet/md-react](https://www.npmjs.com/package/@miljodirektoratet/md-react)_

**Ny test for å se om worker får pushet endringer med PAT, nå bør dette fikses. (alle disse skal squashes senere)**
2 changes: 0 additions & 2 deletions packages/react/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,3 @@ const MyComponent = () => {
**For more documentation, please refer to the [Storybook](https://miljodir.github.io/md-components/)**

_For stylesheets, see [@miljodirektoratet/md-css](https://www.npmjs.com/package/@miljodirektoratet/md-css)_

**Endring for å teste workflow**
1 change: 1 addition & 0 deletions pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ _Replace this text with a detailed description of your changes_
## Checklist before requesting a review

- [ ] I have performed a self-review and test of my code
- [ ] I have added label to the PR (`major`, `minor` or `patch`)
- [ ] If new component: Is story for component created in `stories`-folder?
- [ ] If new component: Is tsx-file import added to `packages/react/index.tsx`?
- [ ] If new component: Is css-file added to `packages/css/index.css`?
Loading